Add fuchsia.intl.PropertyProvider to our services on Fuchsia (flutter#13486)

George Wright · iskakaushik · commit f7d52fab0779 · 2019-11-01T16:13:12.000-07:00
This resolves the following error on Fuchsia: Component fuchsia-pkg://fuchsia.com/flutter_aot_product_runner#meta/flutter_aot_product_runner.cmx is not allowed to connect to fuchsia.intl.PropertyProvider because this service is not present in the component's sandbox.
diff --git a/shell/platform/fuchsia/dart_runner/examples/goodbye_dart/meta/goodbye_dart_aot.cmx b/shell/platform/fuchsia/dart_runner/examples/goodbye_dart/meta/goodbye_dart_aot.cmx
@@ -7,6 +7,7 @@
       "deprecated-ambient-replace-as-executable"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/goodbye_dart/meta/goodbye_dart_jit.cmx b/shell/platform/fuchsia/dart_runner/examples/goodbye_dart/meta/goodbye_dart_jit.cmx
@@ -7,6 +7,7 @@
       "deprecated-ambient-replace-as-executable"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_app_dart/meta/hello_app_dart_aot.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_app_dart/meta/hello_app_dart_aot.cmx
@@ -5,6 +5,7 @@
   "sandbox": {
     "features": [],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_app_dart/meta/hello_app_dart_jit.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_app_dart/meta/hello_app_dart_jit.cmx
@@ -7,6 +7,7 @@
       "deprecated-ambient-replace-as-executable"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_aot.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_aot.cmx
@@ -5,6 +5,7 @@
   "sandbox": {
     "features": [],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_aot_product.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_aot_product.cmx
@@ -5,6 +5,7 @@
   "sandbox": {
     "features": [],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_debug.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_debug.cmx
@@ -5,6 +5,7 @@
   "sandbox": {
     "features": [],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_jit.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_jit.cmx
@@ -7,6 +7,7 @@
       "deprecated-ambient-replace-as-executable"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_jit_product.cmx b/shell/platform/fuchsia/dart_runner/examples/hello_dart/meta/hello_dart_jit_product.cmx
@@ -7,6 +7,7 @@
       "deprecated-ambient-replace-as-executable"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/integration/meta/dart_aot_runner_test.cmx b/shell/platform/fuchsia/dart_runner/integration/meta/dart_aot_runner_test.cmx
@@ -6,6 +6,7 @@
     "services": [
       "fuchsia.cobalt.LoggerFactory",
       "fuchsia.fonts.Provider",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.logger.LogSink",
       "fuchsia.modular.Clipboard",
       "fuchsia.modular.ContextWriter",
diff --git a/shell/platform/fuchsia/dart_runner/integration/meta/dart_jit_runner_test.cmx b/shell/platform/fuchsia/dart_runner/integration/meta/dart_jit_runner_test.cmx
@@ -9,6 +9,7 @@
     "services": [
       "fuchsia.cobalt.LoggerFactory",
       "fuchsia.fonts.Provider",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.logger.LogSink",
       "fuchsia.modular.Clipboard",
       "fuchsia.modular.ContextWriter",
diff --git a/shell/platform/fuchsia/dart_runner/meta/dart_aot_product_runner.cmx b/shell/platform/fuchsia/dart_runner/meta/dart_aot_product_runner.cmx
@@ -9,6 +9,7 @@
     ],
     "services": [
       "fuchsia.feedback.CrashReporter",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.logger.LogSink",
       "fuchsia.net.NameLookup",
       "fuchsia.netstack.Netstack",
diff --git a/shell/platform/fuchsia/dart_runner/meta/dart_jit_product_runner.cmx b/shell/platform/fuchsia/dart_runner/meta/dart_jit_product_runner.cmx
@@ -9,6 +9,7 @@
     ],
     "services": [
       "fuchsia.feedback.CrashReporter",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.logger.LogSink",
       "fuchsia.net.NameLookup",
       "fuchsia.netstack.Netstack",
diff --git a/shell/platform/fuchsia/dart_runner/meta/dart_zircon_test.cmx b/shell/platform/fuchsia/dart_runner/meta/dart_zircon_test.cmx
@@ -8,6 +8,7 @@
       "root-ssl-certificates"
     ],
     "services": [
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Environment"
     ]
   }
diff --git a/shell/platform/fuchsia/dart_runner/vmservice/meta/vmservice.cmx b/shell/platform/fuchsia/dart_runner/vmservice/meta/vmservice.cmx
@@ -6,6 +6,7 @@
     "services": [
       "fuchsia.cobalt.LoggerFactory",
       "fuchsia.fonts.Provider",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.logger.LogSink",
       "fuchsia.modular.Clipboard",
       "fuchsia.modular.ContextWriter",
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx b/shell/platform/fuchsia/flutter/meta/flutter_aot_product_runner.cmx
@@ -15,6 +15,7 @@
       "fuchsia.deprecatedtimezone.Timezone",
       "fuchsia.feedback.CrashReporter",
       "fuchsia.fonts.Provider",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.net.NameLookup",
       "fuchsia.netstack.Netstack",
       "fuchsia.posix.socket.Provider",
diff --git a/shell/platform/fuchsia/flutter/meta/flutter_runner_tests.cmx b/shell/platform/fuchsia/flutter/meta/flutter_runner_tests.cmx
@@ -9,6 +9,7 @@
     ],
     "services": [
       "fuchsia.accessibility.semantics.SemanticsManager",
+      "fuchsia.intl.PropertyProvider",
       "fuchsia.sys.Launcher"
     ]
   }

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`"deprecated-ambient-replace-as-executable"`
`8`	`8`	`],`
`9`	`9`	`"services": [`
	`10`	`+ "fuchsia.intl.PropertyProvider",`
`10`	`11`	`"fuchsia.sys.Environment"`
`11`	`12`	`]`
`12`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`"sandbox": {`
`6`	`6`	`"features": [],`
`7`	`7`	`"services": [`
	`8`	`+ "fuchsia.intl.PropertyProvider",`
`8`	`9`	`"fuchsia.sys.Environment"`
`9`	`10`	`]`
`10`	`11`	`}`