Skip to content

Commit d29cd9b

Browse files
authored
Clean up device logger and port forwarding on drive completion (flutter#68655)
1 parent 8b79906 commit d29cd9b

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

packages/flutter_tools/lib/src/commands/drive.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,8 @@ $ex
386386
globals.printStatus('Stopping application instance.');
387387
await appStopper(this, package);
388388
}
389+
390+
await device?.dispose();
389391
}
390392

391393
return FlutterCommandResult.success();

packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ void main() {
228228
'10',
229229
];
230230
await createTestCommandRunner(command).run(args);
231+
verify(mockDevice.dispose());
231232
expect(testLogger.errorText, isEmpty);
232233
}, overrides: <Type, Generator>{
233234
FileSystem: () => fs,
@@ -529,6 +530,7 @@ void main() {
529530
prebuiltApplication: false,
530531
userIdentifier: anyNamed('userIdentifier'),
531532
));
533+
verify(mockDevice.dispose());
532534
}, overrides: <Type, Generator>{
533535
FileSystem: () => fs,
534536
ProcessManager: () => FakeProcessManager.any(),
@@ -558,6 +560,7 @@ void main() {
558560
prebuiltApplication: false,
559561
userIdentifier: anyNamed('userIdentifier'),
560562
));
563+
verify(mockDevice.dispose());
561564
}, overrides: <Type, Generator>{
562565
FileSystem: () => fs,
563566
ProcessManager: () => FakeProcessManager.any(),

0 commit comments

Comments
 (0)