Skip to content

Commit a5680f9

Browse files
authored
[dart_runner] Initialize logging and tracing (flutter#13829)
Remove !defined(FUCHSIA_SDK) bits to start using the SDK apis to initialize logging and trace events for dart runners.
1 parent 198c2a7 commit a5680f9

File tree

1 file changed

+3
-9
lines changed
  • shell/platform/fuchsia/dart_runner

1 file changed

+3
-9
lines changed

shell/platform/fuchsia/dart_runner/main.cc

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
#include <lib/async-loop/cpp/loop.h>
66
#include <lib/async-loop/default.h>
7+
#include <lib/syslog/global.h>
78
#include <lib/trace-provider/provider.h>
89
#include <lib/trace/event.h>
910

@@ -15,10 +16,6 @@
1516
#include "runtime/dart/utils/tempfs.h"
1617
#include "third_party/dart/runtime/include/dart_api.h"
1718

18-
#if !defined(FUCHSIA_SDK)
19-
#include <lib/syslog/cpp/logger.h>
20-
#endif // !defined(FUCHSIA_SDK)
21-
2219
#if !defined(DART_PRODUCT)
2320
// Register native symbol information for the Dart VM's profiler.
2421
static void RegisterProfilerSymbols(const char* symbols_path,
@@ -34,20 +31,17 @@ static void RegisterProfilerSymbols(const char* symbols_path,
3431
#endif // !defined(DART_PRODUCT)
3532

3633
int main(int argc, const char** argv) {
34+
fx_log_init();
3735
async::Loop loop(&kAsyncLoopConfigAttachToCurrentThread);
3836

39-
#if !defined(FUCHSIA_SDK)
40-
syslog::InitLogger();
41-
4237
std::unique_ptr<trace::TraceProviderWithFdio> provider;
4338
{
44-
TRACE_EVENT0("dart", "CreateTraceProvider");
39+
TRACE_DURATION("dart", "CreateTraceProvider");
4540
bool already_started;
4641
// Use CreateSynchronously to prevent loss of early events.
4742
trace::TraceProviderWithFdio::CreateSynchronously(
4843
loop.dispatcher(), "dart_runner", &provider, &already_started);
4944
}
50-
#endif // !defined(FUCHSIA_SDK)
5145

5246
#if !defined(DART_PRODUCT)
5347
#if defined(AOT_RUNTIME)

0 commit comments

Comments
 (0)