Android Embedding PR 17: Clarify AccessibilityBridge and move logic out of FlutterView. (flutter#8061)

Author: matthew-carroll

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

@@ -20,6 +20,8 @@
 import io.flutter.embedding.engine.FlutterEngine.EngineLifecycleListener;
 import io.flutter.embedding.engine.renderer.FlutterRenderer;
 import io.flutter.embedding.engine.renderer.OnFirstFrameRenderedListener;
+import io.flutter.plugin.common.StandardMessageCodec;
+import io.flutter.view.AccessibilityBridge;
 
 /**
  * Interface between Flutter embedding's Java code and Flutter engine's C/C++ code.
@@ -323,6 +325,22 @@ private native void nativeDispatchPointerDataPacket(long nativePlatformViewId,
                                                       ByteBuffer buffer,
                                                       int position);
 
+  public void dispatchSemanticsAction(int id, @NonNull AccessibilityBridge.Action action) {
+    dispatchSemanticsAction(id, action, null);
+  }
+
+  public void dispatchSemanticsAction(int id, @NonNull AccessibilityBridge.Action action, @Nullable Object args) {
+    ensureAttachedToNative();
+
+    ByteBuffer encodedArgs = null;
+    int position = 0;
+    if (args != null) {
+      encodedArgs = StandardMessageCodec.INSTANCE.encodeMessage(args);
+      position = encodedArgs.position();
+    }
+    dispatchSemanticsAction(id, action.value, encodedArgs, position);
+  }
+
   @UiThread
   public void dispatchSemanticsAction(int id, int action, ByteBuffer args, int argsPosition) {
     ensureAttachedToNative();

shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java

@@ -103,17 +103,17 @@ public interface AccessibilityMessageHandler {
     void announce(@NonNull String message);
 
     /**
-     * The user has tapped on the artifact with the given {@code nodeId}.
+     * The user has tapped on the widget with the given {@code nodeId}.
      */
     void onTap(int nodeId);
 
     /**
-     * The user has long pressed on the artifact with the given {@code nodeId}.
+     * The user has long pressed on the widget with the given {@code nodeId}.
      */
     void onLongPress(int nodeId);
 
     /**
-     * The user has opened a popup window, menu, dialog, etc.
+     * The user has opened a tooltip.
      */
     void onTooltip(@NonNull String message);
   }