Skip to content

Commit 479e27c

Browse files
Update stack trace test goldens to handle engine builds with lazy async stacks (flutter#51216)
The next engine roll will introduce --lazy-async-stacks, which affects the contents of stack traces. This updates test expectations to match both the old and new stack trace formats.
1 parent d5844e8 commit 479e27c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

dev/automated_tests/flutter_test/exception_handling_expectation.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ When the exception was thrown, this was the stack:
99
#(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
1010
<asynchronous suspension>
1111
<<skip until matching line>>
12-
^\(elided [0-9]+ frames.+$
12+
^\(elided ([0-9]+|one) frame.+$
1313
<<skip until matching line>>
1414
The test description was:
1515
Exception handling in test harness - string
@@ -29,7 +29,7 @@ When the exception was thrown, this was the stack:
2929
#(1|2) .+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
3030
<asynchronous suspension>
3131
<<skip until matching line>>
32-
^\(elided [0-9]+ .+$
32+
^\(elided ([0-9]+|one) .+$
3333
<<skip until matching line>>
3434
The test description was:
3535
Exception handling in test harness - FlutterError
@@ -52,7 +52,7 @@ When the exception was thrown, this was the stack:
5252
<<skip until matching line>>
5353
#[0-9]+ +.+ \(package:flutter_test[/\\]src[/\\]widget_tester\.dart:[0-9]+:[0-9]+\)
5454
<<skip until matching line>>
55-
^\(elided [0-9]+ .+$
55+
^\(elided ([0-9]+|one) .+$
5656
<<skip until matching line>>
5757
The test description was:
5858
Exception handling in test harness - uncaught Future error

dev/automated_tests/flutter_test/test_async_utils_unguarded_expectation.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ statement in front of the call to the first\.
1515

1616
When the first method was called, this was the stack:
1717
<<skip until matching line>>
18-
(elided [0-9]+ frames from .+)
18+
(elided ([0-9]+|one) frames? from .+)
1919

2020
When the exception was thrown, this was the stack:
2121
<<skip until matching line>>
22-
(elided [0-9]+ frames from .+)
22+
(elided ([0-9]+|one) frames? from .+)
2323

2424
The test description was:
2525
TestAsyncUtils - handling unguarded async helper functions

0 commit comments

Comments
 (0)