Skip to content

Commit 1ce85be

Browse files
[flutter_runner] Enable Skia tracing by default on Fuchsia (flutter#13457)
Since Flutter tracing is wired up to Fuchsia system level tracing (and that includes Skia tracing within Flutter), it makes more sense to enable Skia tracing by default on Fuchsia, and to control Flutter Skia tracing, rely on whether Fuchsia system tracing is enabled, in progress, and contains the "skia" category.
1 parent 897ce34 commit 1ce85be

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

shell/platform/fuchsia/flutter/component.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,9 +316,8 @@ Application::Application(
316316
settings_.observatory_host = "127.0.0.1";
317317
#endif
318318

319-
// Set this to true to enable category "skia" trace events.
320-
// TODO(PT-145): Explore enabling this by default.
321-
settings_.trace_skia = false;
319+
// Controls whether category "skia" trace events are enabled.
320+
settings_.trace_skia = true;
322321

323322
settings_.icu_data_path = "";
324323

0 commit comments

Comments
 (0)