Skip to content

Commit 1bcb96b

Browse files
authored
Add framework test in engine presubmit checks (flutter#8664)
With this, no Skia or Dart roll (or any other engine commit) would accidentally break the framework. For commits that require manual engine-to-framework rolls, the `build_and_test_host` test would fail. In such cases, the author should explicitly mention **"merge on red as the failure is expected; the engine will be manually rolled into the framework"**.
1 parent 6e79dcd commit 1bcb96b

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

.cirrus.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ task:
1313
ENGINE_PATH: "/tmp/clean_engine"
1414
DEPOT_TOOLS: "/tmp/depot_tools"
1515
PATH: "$DEPOT_TOOLS:$PATH"
16+
FLUTTER_ENGINE: "/tmp/clean_engine/src"
17+
FRAMEWORK_PATH: "/tmp/master_framework"
1618
depot_tools_script:
1719
git clone --depth 1 https://chromium.googlesource.com/chromium/tools/depot_tools.git $DEPOT_TOOLS
1820
gclient_sync_script: |
@@ -31,6 +33,13 @@ task:
3133
./flutter/tools/gn --unoptimized
3234
ninja -C out/host_debug_unopt
3335
test_host_script: cd $ENGINE_PATH/src && ./flutter/testing/run_tests.sh host_debug_unopt
36+
fetch_framework_script: |
37+
mkdir -p $FRAMEWORK_PATH
38+
cd $FRAMEWORK_PATH
39+
git clone https://github.com/flutter/flutter.git
40+
framework_test_script: |
41+
cd $FRAMEWORK_PATH/flutter/packages/flutter
42+
../../bin/flutter test --local-engine=host_debug_unopt
3443
- name: build_and_test_host_profile
3544
compile_host_script: |
3645
cd $ENGINE_PATH/src

0 commit comments

Comments
 (0)