Skip to content

Commit 1a6eada

Browse files
fix failing lint : findByPath requires a specific ordering of project evaluation in flutter.groovy (flutter#159296)
fix failing lint : `'findByPath' requires a specific ordering of project evaluation` ![Capture d’écran 2024-11-21 230157](https://github.com/user-attachments/assets/61ab84da-4941-4aa4-a42e-fac4c140f4bd) ![Capture d’écran 2024-11-21 230245](https://github.com/user-attachments/assets/417563b7-0416-47bd-9f02-6778d37893ef) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Reid Baker <reidbaker@google.com>
1 parent 43a25a8 commit 1a6eada

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

packages/flutter_tools/gradle/src/main/groovy/flutter.groovy

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,8 +1259,18 @@ class FlutterPlugin implements Plugin<Project> {
12591259
boolean isBuildingAar = project.hasProperty("is-plugin")
12601260
// In add to app scenarios, a Gradle project contains a `:flutter` and `:app` project.
12611261
// `:flutter` is used as a subproject when these tasks exists and the build isn't building an AAR.
1262-
Task packageAssets = project.tasks.findByPath(":flutter:package${variant.name.capitalize()}Assets")
1263-
Task cleanPackageAssets = project.tasks.findByPath(":flutter:cleanPackage${variant.name.capitalize()}Assets")
1262+
Task packageAssets
1263+
Task cleanPackageAssets
1264+
try {
1265+
packageAssets = project.tasks.named("package${variant.name.capitalize()}Assets").get()
1266+
} catch (UnknownTaskException ignored) {
1267+
packageAssets = null
1268+
}
1269+
try {
1270+
cleanPackageAssets = project.tasks.named("cleanPackage${variant.name.capitalize()}Assets").get()
1271+
} catch (UnknownTaskException ignored) {
1272+
cleanPackageAssets = null
1273+
}
12641274
boolean isUsedAsSubproject = packageAssets && cleanPackageAssets && !isBuildingAar
12651275

12661276
String variantBuildMode = buildModeFor(variant.buildType)

0 commit comments

Comments
 (0)