Skip to content

Commit 14fc0e5

Browse files
chunhtaifluttergithubbot
authored andcommitted
soft transition for the mustcallsuper in Element forgetChild (flutter#49246)
1 parent 0fffa51 commit 14fc0e5

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

packages/flutter/lib/src/widgets/framework.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3349,7 +3349,12 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
33493349
/// The element will still have a valid parent when this is called. After this
33503350
/// is called, [deactivateChild] is called to sever the link to this object.
33513351
@protected
3352-
void forgetChild(Element child);
3352+
void forgetChild(Element child) {
3353+
// TODO(chunhtai): Creates empty body for subclass to call super. This will
3354+
// enable us to fix internal tests pro-actively for upcoming breaking
3355+
// change.
3356+
// https://github.com/flutter/flutter/issues/43780.
3357+
}
33533358

33543359
void _activateWithParent(Element parent, dynamic newSlot) {
33553360
assert(_debugLifecycleState == _ElementLifecycle.inactive);

0 commit comments

Comments
 (0)