Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventvalue re-written #234

Closed
Amonbofils opened this issue Jun 1, 2021 · 4 comments
Closed

eventvalue re-written #234

Amonbofils opened this issue Jun 1, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@Amonbofils
Copy link

Hi,

i found something wrong. In a rule i wrote that script :

// Request events for fermenting tank 2
On setTemp_2 do
TaskValueSet 5,2,%eventvalue%
TaskValueSet 14,2,%eventvalue%+0.5
TaskValueSet 15,2,%eventvalue%-0.1
endon

What i wanted, and i suppose it has to work is :

If eventvalue is like 20, then TaskValueSet 14,2 is supposed to be 20.5 and taskValueSet 15,2 is supposed to be 19.9.

But, really it's 14,2 at 20.5 (that's ok) and 15,2 is 20.4.

eventvalue seems to be re-written by the TaskValueSet insctuction.

Is it normal or wrong ?

Thanks

@enesbcs
Copy link
Owner

enesbcs commented Jun 15, 2021

This behaviour is a result of the requested feature to add taskvalues as eventvalues.. which i think will restore to its original state as it is not good.

@TD-er
Copy link

TD-er commented Jun 15, 2021

This behaviour is a result of the requested feature to add taskvalues as eventvalues.. which i think will restore to its original state as it is not good.

You should keep the eventvalues and the events together.
In ESPEasy I create a string for an event, including the eventvalues. So no matter if it is put in a queue, or dealt with immediately, the events and eventvalues stay together and don't change.

@enesbcs
Copy link
Owner

enesbcs commented Nov 23, 2021

Reverted back to original RPIEasy behavior, at commit fadb803 taskvaluset do not overwrite eventvalues anymore.
Closing.

@enesbcs
Copy link
Owner

enesbcs commented Dec 21, 2021

#219 (comment)

@enesbcs enesbcs reopened this Dec 21, 2021
@enesbcs enesbcs added the bug Something isn't working label Dec 21, 2021
@enesbcs enesbcs closed this as completed Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants