TemplateEditor: Remove the OPTION parameter type

Instead, we infer that a parameter has a set of options by the existence
of an OptionData as its default value.

https://phabricator.endlessm.com/T35564

Author: dylanmccall

addons/block_code/blocks/graphics/animationplayer_play.tres

@@ -1,4 +1,4 @@
-[gd_resource type="Resource" load_steps=5 format=3 uid="uid://c5e1byehtxwc0"]
+[gd_resource type="Resource" load_steps=6 format=3 uid="uid://c5e1byehtxwc0"]
 
 [ext_resource type="Script" path="res://addons/block_code/code_generation/block_definition.gd" id="1_emeuv"]
 [ext_resource type="Script" path="res://addons/block_code/ui/block_canvas/option_data.gd" id="1_xu43h"]
@@ -9,6 +9,11 @@ script = ExtResource("1_xu43h")
 selected = 0
 items = ["ahead", "backwards"]
 
+[sub_resource type="Resource" id="Resource_qpxn2"]
+script = ExtResource("1_xu43h")
+selected = 0
+items = []
+
 [resource]
 script = ExtResource("1_emeuv")
 name = &"animationplayer_play"
@@ -17,13 +22,14 @@ description = "Play the animation."
 category = "Graphics | Animation"
 type = 2
 variant_type = 0
-display_template = "Play {animation: OPTION} {direction: OPTION}"
+display_template = "Play {animation: NIL} {direction: NIL}"
 code_template = "if \"{direction}\" == \"ahead\":
 	play(\"{animation}\")
 else:
 	play_backwards(\"{animation}\")
 "
 defaults = {
+"animation": SubResource("Resource_qpxn2"),
 "direction": SubResource("Resource_vnp2w")
 }
 signal_name = ""

addons/block_code/blocks/logic/compare.tres

@@ -16,7 +16,7 @@ description = ""
 category = "Logic | Comparison"
 type = 3
 variant_type = 1
-display_template = "{float1: FLOAT} {op: OPTION} {float2: FLOAT}"
+display_template = "{float1: FLOAT} {op: NIL} {float2: FLOAT}"
 code_template = "{float1} {op} {float2}"
 defaults = {
 "float1": 1.0,

addons/block_code/blocks/sounds/pause_continue_sound.tres

@@ -6,7 +6,7 @@
 [sub_resource type="Resource" id="Resource_lalgp"]
 script = ExtResource("1_ilhdq")
 selected = 0
-items = ["Pause", "Continue"]
+items = ["pause", "continue"]
 
 [resource]
 script = ExtResource("1_q04gm")
@@ -16,7 +16,7 @@ description = "Pause/Continue the audio stream"
 category = "Sounds"
 type = 2
 variant_type = 0
-display_template = "{pause: OPTION} the sound {name: STRING}"
+display_template = "{pause: NIL} the sound {name: STRING}"
 code_template = "var __sound_node = get_node({name})
 if \"{pause}\" == \"pause\":
 	__sound_node.stream_paused = true

addons/block_code/ui/blocks/utilities/template_editor/template_editor.gd

@@ -111,13 +111,11 @@ func _append_input_parameter(parameter_format: String, id: int):
 	parameter_input.placeholder = parameter["name"]
 	parameter_input.variant_type = parameter["type"]
 
-	if parameter["is_option"] and default_value is OptionData:
+	if default_value is OptionData:
 		var option_data := default_value as OptionData
 		parameter_input.option_data = option_data
 		if option_data.selected < option_data.items.size():
 			parameter_input.default_value = option_data.items[option_data.selected]
-	elif parameter["is_option"]:
-		push_warning("The block parameter %s in %s appears to be an option, but no option data is provided" % [parameter_format, parent_block])
 	else:
 		parameter_input.default_value = default_value
 
@@ -146,7 +144,6 @@ func _parse_parameter_format(parameter_format: String) -> Dictionary:
 	var parameter_name: String
 	var parameter_type_str: String
 	var parameter_type: Variant.Type
-	var is_option: bool
 	var split := parameter_format.split(":", true, 1)
 
 	if len(split) == 0:
@@ -158,9 +155,7 @@ func _parse_parameter_format(parameter_format: String) -> Dictionary:
 	if len(split) > 1:
 		parameter_type_str = split[1].strip_edges()
 
-	if parameter_type_str and parameter_type_str == "OPTION":
-		is_option = true
-	elif parameter_type_str:
+	if parameter_type_str:
 		parameter_type = Types.STRING_TO_VARIANT_TYPE[parameter_type_str]
 
-	return {"name": parameter_name, "type": parameter_type, "is_option": is_option}
+	return {"name": parameter_name, "type": parameter_type}