Support R_MIPS_GPREL16 relocations correctly #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symbols defined in the same file require adding a special ri_gp_value from the .reginfo section to their relocation calculations.
|
Looks like you're using nightly for fmt. Hopefully the code style is fixed now. |
encounter
reviewed
Aug 8, 2024
SquareMan
force-pushed
the
r_mips_gprel16
branch
from
bea8914 to
b1e300b
Compare
|
Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in discord.
synopsis: objdiff does not currently read the
ri_gp_valuefield from the.reginfoheader for MIPS objects, which is required to calculateR_MIPS_GPREL16relocations for local symbols.This PR attempts to correct that. Passing the file to
implicit_addendis required to determine whether the symbol being relocated against is local or not.