Skip to content

Fix release CI (and add sccache) #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

ribbanya
Copy link
Contributor

@ribbanya ribbanya commented Mar 3, 2024

sccache saves a little bit of time, it's hard to say how much. On ubuntu-latest it's like 3 minutes saved, but on Windows it's more marginal. 🤷

contents: write was necessary to avoid 403 errors on my fork.

@ribbanya
Copy link
Contributor Author

ribbanya commented Mar 3, 2024

Actually this will release the GUI as objdiff-gui and not objdiff. I can fix that, just let me know.

@encounter
Copy link
Owner

Yeah, I’d like to keep the binary name objdiff instead of -gui because of the auto updater.

@ribbanya
Copy link
Contributor Author

ribbanya commented Mar 3, 2024

Fixed.

@encounter encounter merged commit 341c1d4 into encounter:main Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants