Skip to content

Commit 304df96

Browse files
authored
Display decoded rlwinm info to hover tooltip (#141)
* Fix missing dependency feature for objdiff-gui * Update .gitignore * Display decoded rlwinm info to hover tooltip * Remove trailing newline when displaying decoded rlwinm info * Change variable name * Also update variable name in rlwinm.rs
1 parent 7aa878b commit 304df96

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ android.keystore
1818
*.frag
1919
*.vert
2020
*.metal
21-
.vscode/launch.json
21+
.vscode/

objdiff-gui/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ exec = "0.3"
9595

9696
# native:
9797
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
98-
tracing-subscriber = "0.3"
98+
tracing-subscriber = { version = "0.3", features = ["env-filter"] }
9999

100100
# web:
101101
[target.'cfg(target_arch = "wasm32")'.dependencies]

objdiff-gui/src/views/function_diff.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,10 @@ fn ins_hover_ui(
149149
ui.colored_label(appearance.highlight_color, "Extern".to_string());
150150
}
151151
}
152+
153+
if let Some(decoded) = rlwinmdec::decode(&ins.formatted) {
154+
ui.colored_label(appearance.highlight_color, decoded.trim());
155+
}
152156
});
153157
}
154158

objdiff-gui/src/views/rlwinm.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ pub fn rlwinm_decode_window(
1616
egui::Window::new("Rlwinm Decoder").open(show).show(ctx, |ui| {
1717
ui.text_edit_singleline(&mut state.text);
1818
ui.add_space(10.0);
19-
if let Some(demangled) = rlwinmdec::decode(&state.text) {
19+
if let Some(decoded) = rlwinmdec::decode(&state.text) {
2020
ui.scope(|ui| {
2121
ui.style_mut().override_text_style = Some(TextStyle::Monospace);
22-
ui.colored_label(appearance.replace_color, &demangled);
22+
ui.colored_label(appearance.replace_color, decoded.trim());
2323
});
2424
if ui.button("Copy").clicked() {
25-
ui.output_mut(|output| output.copied_text = demangled);
25+
ui.output_mut(|output| output.copied_text = decoded);
2626
}
2727
} else {
2828
ui.scope(|ui| {

0 commit comments

Comments
 (0)