Hide certain symbols for X360 COFFs (#248)

rjkiv · web-flow · commit 0b95613768ff · 2025-08-31T16:45:21.000-06:00
* hide except_data symbols

* hide unwinds by default

* move COFF filters to obj/read.rs

* cargo fmt read.rs

* clippy moment

* clippy pls
diff --git a/objdiff-core/src/obj/read.rs b/objdiff-core/src/obj/read.rs
@@ -74,6 +74,14 @@ fn map_symbol(
     {
         flags |= SymbolFlag::Hidden;
     }
+    if file.format() == object::BinaryFormat::Coff
+        && let Ok(name) = symbol.name()
+        && (name.starts_with("except_data_")
+            || name.starts_with("__unwind")
+            || name.starts_with("__catch"))
+    {
+        flags |= SymbolFlag::Hidden;
+    }
 
     let kind = match symbol.kind() {
         object::SymbolKind::Text => SymbolKind::Function,

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,14 @@ fn map_symbol(`
`74`	`74`	`{`
`75`	`75`	`flags \|= SymbolFlag::Hidden;`
`76`	`76`	`}`
	`77`	`+ if file.format() == object::BinaryFormat::Coff`
	`78`	`+ && let Ok(name) = symbol.name()`
	`79`	`+ && (name.starts_with("except_data_")`
	`80`	`+ \|\| name.starts_with("__unwind")`
	`81`	`+ \|\| name.starts_with("__catch"))`
	`82`	`+ {`
	`83`	`+ flags \|= SymbolFlag::Hidden;`
	`84`	`+ }`
`77`	`85`
`78`	`86`	`let kind = match symbol.kind() {`
`79`	`87`	`object::SymbolKind::Text => SymbolKind::Function,`