Skip to content

docs: remove consecutive duplicate words #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zeroprooff
Copy link

hey team! I found duplicate words and fixed them.

@encore-cla
Copy link

encore-cla bot commented Apr 17, 2025

All committers have signed the CLA.

@@ -51,7 +51,7 @@ pub static SERVICE_PARSER: ResourceParser = ResourceParser {
}

// This resource is only allowed to be defined in a module named "encore.service.ts".
// Check that that is the case.
// Check that is the case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version was correct.

@@ -1,5 +1,5 @@
! parse
err 'The function passed to `pubsub.NewSubscription` must be declared in the the same service as the'
err 'The function passed to `pubsub.NewSubscription` must be declared in the same service as the'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing that the parser returns a specific error. You'll need to update the code that returns that error, too, otherwise the test will fail

Update service.rs

Update pubsub_err_subscriber_different_service.txt
@zeroprooff
Copy link
Author

@eandre ready , thanks

Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still haven't addressed where this error message is actually generated. You're just changing the tests.

@zeroprooff
Copy link
Author

v2/parser/infra/pubsub/errors.go # ~стр. 80‑90
var ErrSubscriptionFuncDifferentService = errRange.New(
"Invalid subscriber for pubsub.NewSubscription",
"The function passed to pubsub.NewSubscription must be declared in the same service as the call to pubsub.NewSubscription.",
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants