-
Notifications
You must be signed in to change notification settings - Fork 400
docs: remove consecutive duplicate words #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All committers have signed the CLA. |
@@ -51,7 +51,7 @@ pub static SERVICE_PARSER: ResourceParser = ResourceParser { | |||
} | |||
|
|||
// This resource is only allowed to be defined in a module named "encore.service.ts". | |||
// Check that that is the case. | |||
// Check that is the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version was correct.
@@ -1,5 +1,5 @@ | |||
! parse | |||
err 'The function passed to `pubsub.NewSubscription` must be declared in the the same service as the' | |||
err 'The function passed to `pubsub.NewSubscription` must be declared in the same service as the' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing that the parser returns a specific error. You'll need to update the code that returns that error, too, otherwise the test will fail
Update service.rs Update pubsub_err_subscriber_different_service.txt
@eandre ready , thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still haven't addressed where this error message is actually generated. You're just changing the tests.
v2/parser/infra/pubsub/errors.go # ~стр. 80‑90 |
hey team! I found duplicate words and fixed them.