cli/daemon: support watching embedded files #1667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
|
As much as this functionality would be desirable, the solution is not performant enough to read every single file that has a file modification event. I'm afraid it's a bit of a non-starter as is written. |
bn4t
force-pushed
the
watch-embedded-files
branch
2 times, most recently
from
2280480 to
533eeaf
Compare
|
@eandre Thanks for the feedback. I added now tracking of embedded files, so that embedding or unembedding a new file doesn't cause a rescan of the whole project directory tree. What do you think of this implementation? |
bn4t
force-pushed
the
watch-embedded-files
branch
from
533eeaf to
cfab064
Compare
bn4t
force-pushed
the
watch-embedded-files
branch
from
cfab064 to
e88a572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #416.
Added a very basic implementation to support watching files embedded using
//go:embed.Might make sense to track go files using watcher events instead of walking the whole project every time. Let me know if you want me to add that.