From 1f253904ed62f169e457d2819ee6c96e1c2e5f04 Mon Sep 17 00:00:00 2001 From: Zhanara <91150590+SourbaevaJanaraJ@users.noreply.github.com> Date: Fri, 10 Feb 2023 00:02:44 +0600 Subject: [PATCH] enabled more lint (#996) * cloned app * enabled no_default_cases: true --- analysis_options.yaml | 2 +- flutterw | 2 +- .../menu/camera/image_picker_scaffold.dart | 18 ++++++------------ .../ceremony_box/ceremony_box.dart | 3 --- .../payment_confirmation_page/index.dart | 4 ---- lib/page/qr_scan/qr_scan_service.dart | 4 ---- lib/service/deep_link/deep_link.dart | 3 --- lib/service/tx/lib/src/submit_to_js.dart | 6 +++--- lib/store/encointer/encointer.dart | 2 -- 9 files changed, 11 insertions(+), 33 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index c96fed748..cbc2f96d5 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -6,7 +6,7 @@ linter: directives_ordering: false sort_pub_dependencies: false flutter_style_todos: false - no_default_cases: false + no_default_cases: true use_named_constants: false avoid_positional_boolean_parameters: false comment_references: false diff --git a/flutterw b/flutterw index 2079315c7..9882dc8a6 100755 --- a/flutterw +++ b/flutterw @@ -4,7 +4,7 @@ ## ## Flutter start up script for UN*X ## Version: v1.3.1 -## Date: 2022-12-22 21:01:55 +## Date: 2023-02-08 19:57:46 ## ## Use this flutter wrapper to bundle Flutter within your project to make ## sure everybody builds with the same version. diff --git a/lib/page-encointer/bazaar/menu/camera/image_picker_scaffold.dart b/lib/page-encointer/bazaar/menu/camera/image_picker_scaffold.dart index 6c98770e2..c22890050 100644 --- a/lib/page-encointer/bazaar/menu/camera/image_picker_scaffold.dart +++ b/lib/page-encointer/bazaar/menu/camera/image_picker_scaffold.dart @@ -36,18 +36,12 @@ class ImagePickerScaffold extends StatelessWidget { ); case ConnectionState.done: return const ImagePreview(); - default: - if (snapshot.hasError) { - return Text( - 'Pick image/video error: ${snapshot.error}}', - textAlign: TextAlign.center, - ); - } else { - return Text( - I18n.of(context)!.translationsForLocale().bazaar.imageNotPicked, - textAlign: TextAlign.center, - ); - } + //Here I'll need your help + case ConnectionState.active: + return Text( + I18n.of(context)!.translationsForLocale().bazaar.imageNotPicked, + textAlign: TextAlign.center, + ); } }, ) diff --git a/lib/page-encointer/ceremony_box/ceremony_box.dart b/lib/page-encointer/ceremony_box/ceremony_box.dart index b5bd6989a..0b035690a 100644 --- a/lib/page-encointer/ceremony_box/ceremony_box.dart +++ b/lib/page-encointer/ceremony_box/ceremony_box.dart @@ -188,9 +188,6 @@ Widget getMeetupInfoWidget(BuildContext context, AppStore store) { ); } } - default: - Log.d("'getMeetupInfoWidget' trapped in an unexpected default case", 'CeremonyBox'); - return Container(); } } diff --git a/lib/page/assets/transfer/payment_confirmation_page/index.dart b/lib/page/assets/transfer/payment_confirmation_page/index.dart index 935f2abbe..c3c03d623 100644 --- a/lib/page/assets/transfer/payment_confirmation_page/index.dart +++ b/lib/page/assets/transfer/payment_confirmation_page/index.dart @@ -208,8 +208,6 @@ class _PaymentConfirmationPageState extends State with ), ), ); - default: - return const Text('Unknown transfer state'); } } @@ -253,8 +251,6 @@ class _PaymentConfirmationPageState extends State with style: h2Grey, ); } - default: - return const Text('Unknown transfer state'); } } diff --git a/lib/page/qr_scan/qr_scan_service.dart b/lib/page/qr_scan/qr_scan_service.dart index a04de839a..c0f41c629 100644 --- a/lib/page/qr_scan/qr_scan_service.dart +++ b/lib/page/qr_scan/qr_scan_service.dart @@ -37,8 +37,6 @@ class QrScanService { return InvoiceQrCode.fromQrFields(data); case QrCodeContext.voucher: return VoucherQrCode.fromQrFields(data); - default: - throw const FormatException('[parseQrScan] Unhandled qr scan context'); } } @@ -50,8 +48,6 @@ class QrScanService { return handleInvoiceQrCodeScan(context, scanContext, qrCode as InvoiceQrCode); case QrCodeContext.voucher: return handleVoucherQrCodeScan(context, scanContext, qrCode as VoucherQrCode); - default: - throw const FormatException('[handleQrScan] Unhandled qr scan context'); } } } diff --git a/lib/service/deep_link/deep_link.dart b/lib/service/deep_link/deep_link.dart index 2ad98c666..b468f7555 100644 --- a/lib/service/deep_link/deep_link.dart +++ b/lib/service/deep_link/deep_link.dart @@ -59,8 +59,5 @@ Future _navigationWithWrScanContext(BuildContext context, QrCode ReapVoucherPage.route, arguments: ReapVoucherParams(voucher: qrCode.data as VoucherData), ); - break; - default: - break; } } diff --git a/lib/service/tx/lib/src/submit_to_js.dart b/lib/service/tx/lib/src/submit_to_js.dart index 4270a4450..2d5a724fd 100644 --- a/lib/service/tx/lib/src/submit_to_js.dart +++ b/lib/service/tx/lib/src/submit_to_js.dart @@ -132,6 +132,9 @@ void _onTxFinish( } String getTxStatusTranslation(TranslationsHome dic, TxStatus? status) { + if (status == null) { + return ''; + } switch (status) { case TxStatus.Queued: return dic.txQueued; @@ -145,9 +148,6 @@ String getTxStatusTranslation(TranslationsHome dic, TxStatus? status) { return dic.txInBlock; case TxStatus.Error: return dic.txError; - default: - Log.d('Illegal TxStatus supplied to translation: $status', 'getTxStatusTranslation'); - return ''; } } diff --git a/lib/store/encointer/encointer.dart b/lib/store/encointer/encointer.dart index 3abdd2caf..e427db74a 100644 --- a/lib/store/encointer/encointer.dart +++ b/lib/store/encointer/encointer.dart @@ -509,8 +509,6 @@ abstract class _EncointerStore with Store { return nextPhaseTimestamp! - phaseDurations[CeremonyPhase.Attesting]! - phaseDurations[CeremonyPhase.Assigning]!; - default: - return null; } }