Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using deprecated macro AC_PROG_LIBTOOL #9

Open
szpak opened this issue Feb 4, 2016 · 3 comments
Open

Using deprecated macro AC_PROG_LIBTOOL #9

szpak opened this issue Feb 4, 2016 · 3 comments

Comments

@szpak
Copy link
Contributor

szpak commented Feb 4, 2016

The work to make network-manager-sstp natively available in Fedora is slowly moving forward. By the way a checked told me that:

[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
AC_PROG_LIBTOOL found in: NetworkManager-sstp-0.9.10/configure.ac:17

It's not a blocker as I expect to have already generated configure file available in a tarball, but by the way of the further changes you could think about replacing it with LT_INIT.

@enaess
Copy link
Owner

enaess commented Feb 4, 2016

Thanks for helping out the Fedora project. Do you have any patches that you'd worked on and like to see committed? I am not very familiar with the LT_INIT you are talking about, are you able to collaborate?

@szpak
Copy link
Contributor Author

szpak commented Feb 4, 2016

Unfortunately I haven't used C and related build tools for years. When I replaced AC_PROG_LIBTOOL with LT_INIT in configure.ac autogen command generated the same configure file. However maybe it was generate from some other file...

@szpak
Copy link
Contributor Author

szpak commented Feb 4, 2016

With commented out LT_INIT different configure file is generated, so probably the change (from AC_PROG_LIBTOOL to LT_INIT) is safe (configure file does not change in comparison to the current version). I will play with it a little more and probably create a very small PR :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants