Skip to content

Commit 217690f

Browse files
WRO-266: Unskip one of Skinnable unit test cases (#3056)
* updated skipped test for Skinnable * lint warning fixes * lint warning fixes * Update unit test Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) * Fix lint warnings Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com) Co-authored-by: Daniel Stoian <daniel.stoian@lgepartner.com>
1 parent b4b5904 commit 217690f

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

packages/ui/Skinnable/tests/Skinnable-specs.js

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ describe('Skinnable Specs', () => {
376376
expect(component).toHaveClass(expected);
377377
});
378378

379-
test.skip('should not force re-render of child if child unaffected', () => {
379+
test('should not force re-render of child if child unaffected', () => {
380380
const config = {
381381
defaultSkin: 'dark',
382382
defaultVariants: 'normal',
@@ -400,19 +400,33 @@ describe('Skinnable Specs', () => {
400400
const SkinnableParent = Skinnable(config, Component);
401401
const SkinnableChild = Skinnable(config, ChildComponent);
402402

403-
// eslint-disable-next-line
404-
const subject = mount(
403+
const childrenProp = (<SkinnableChild />);
404+
405+
const {rerender} = render(
405406
<SkinnableParent>
406-
<SkinnableChild />
407+
{childrenProp}
408+
</SkinnableParent>
409+
);
410+
411+
rerender(
412+
<SkinnableParent className="foo">
413+
{childrenProp}
407414
</SkinnableParent>
408415
);
409416

410-
// Sending props to force parent to re-render
411-
subject.setProps({className: 'foo'});
417+
const expected1 = 1;
418+
const actual1 = wasRendered.mock.calls.length;
419+
420+
rerender(
421+
<SkinnableParent className="foo" skin="light">
422+
{childrenProp}
423+
</SkinnableParent>
424+
);
412425

413-
const expected = 1;
414-
const actual = wasRendered.mock.calls.length;
426+
const expected2 = 2;
427+
const actual2 = wasRendered.mock.calls.length;
415428

416-
expect(actual).toEqual(expected);
429+
expect(actual1).toEqual(expected1);
430+
expect(actual2).toEqual(expected2);
417431
});
418432
});

0 commit comments

Comments
 (0)