Skip to content

WRN-19694: Update to React18 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 4, 2022
Merged

WRN-19694: Update to React18 #266

merged 9 commits into from
Apr 4, 2022

Conversation

MikyungKim
Copy link
Contributor

In this PR, updated react version to 18 and related packages.

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

@MikyungKim
update react version
452b60d 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
Merge branch 'feature/webpack5' into feature/react-18
f302ffc
@MikyungKim
update testing library for react18
9f4eeca 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
update react version
1cdc0aa 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
update dependencies
8df0ac2 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
Merge branch 'feature/webpack5' into feature/react-18
b2c224d
@MikyungKim
update version
1ae6abe 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@MikyungKim
update dev-utils branch
9c2cfaf 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
hong6316
hong6316 reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're 7 vulnerabilities when npm i.
But the root cause is webpack-dev-server @4.6.0 that need to remain version-fixing(cannot be upgraded this time).
I think the current status need to be kept but check it later.

hong6316
hong6316 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, LGTM

@MikyungKim
revert dev-utils version
992674a 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
@hong6316 hong6316 merged commit b2d1a0d into feature/webpack5 Apr 4, 2022
@hong6316 hong6316 deleted the feature/react-18 branch April 4, 2022 06:16
hong6316 added a commit that referenced this pull request Apr 11, 2022
@MikyungKim @hong6316
WRO-231: Merge feature/webpack5 to develop (#268)
0116859 
* WRN-18582: Migrate to webpack5 (#264)

* WRN-18582: webpack5 initial commit

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-18582: Fixed serve issue

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-18582: Added webpack cache config

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* applied more changes

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Added changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update `listen` to `startCallback` from webpack dev server

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix filename..ext issue

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-16762: Added support for tailwindcss and update dependencies (#263)

* initial modules update(before wp5 update)

* npm audit fix

* Update package.json

* fix lint errors

* update CHANGELOG.md

* Update package.json

* revert CHANGELOG.mx

* revert jest 27

* revert npm-shrinkwrap.json

* revert pack/serve.js

* for removing conflict with #262, revert versions

* Update react-refresh-webpack-plugin version

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update babel-jest version

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update babel-plugin-dev-expression version

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* remove unnecessary code

* revert file permission

* update dependencies

* update package.json

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update package.json

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* update changelog and package.json

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>

* WRN-12124: Remove deprecated babel-eslint module (#261)

* use @babel/eslint-parser

* remove babel-preset-react-app

* remove @babel/eslint-parser

* Revert "remove @babel/eslint-parser"

This reverts commit 1b8b37e.

* Revert "remove babel-preset-react-app"

This reverts commit b8579cb.

* Revert "use @babel/eslint-parser"

This reverts commit b73146a.

* babel-eslint -> @babel/eslint-parser

* unpinning enact repos

* remove babel-eslint related word in README.md

* Update README.md

* modify changelog & readme

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update README.md

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* update npm-shrinkwrap.json

* update @babel/core to the same version of dev-utils

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Move some dependencies to dev dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRN-19252: Pass ProgressPlugin to VerboseLogPlugin (#265)

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-12748: Update eslint 8 related modules (#262)

* update eslint 8

* eslint 8 changes strict package exports(#14706), call another method

* revert js changes

* Update package.json

* restore eslintrc.js - 'prettier' (included 'prettier/babel', 'prettier/react')

* Update package.json

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRN-19694: Update to React18 (#266)

* update react version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update testing library for react18

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update react version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dev-utils branch

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* revert dev-utils version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-20481: Fix screenshot test build fail (#267)

* Added node-polyfill-webpack-plugin

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* added some comments

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* link dev-utils

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* WRN-20481: Fix lint error and revert packages version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update change log

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hong6316 hong6316 hong6316 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikyungKim @hong6316