[testing] Fix disable browser auto config. #25384
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now use `--no-browser-auto-config` or the env variable.
sbc100
reviewed
Sep 25, 2025
| parser.add_argument('--headless', action='store_true', | ||
| help='Run browser tests in headless mode.', default=None) | ||
| parser.add_argument('--browser-auto-config', type=bool, default=True, | ||
| parser.add_argument('--browser-auto-config', action=argparse.BooleanOptionalAction, default=None, |
There was a problem hiding this comment.
Hmm.. i've never seen that before. Does it magically provide the --no- variant?
There was a problem hiding this comment.
Yeah, just learned about it the other day.
There was a problem hiding this comment.
Err...I guess it's too new. Not available until 3.9.
sbc100
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now use
--no-browser-auto-configor the env variable.