Looking up ip for localhost should return 127.0.0.1 #24593
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
added a commit
to hoodmane/cpython
that referenced
this pull request
Jun 17, 2025
It's failing because `gethostbyname_r()` is returning an incorrect ip address for `localhost`. Will be resolved by upstream PR: emscripten-core/emscripten#24593
|
I think I tried to make this same patch once and ran into issue.. I can't remember exactly where now.. |
freakboy3742
pushed a commit
to python/cpython
that referenced
this pull request
Jun 18, 2025
Emscripten currently `gethostbyname_r()` returns an incorrect IP address for `localhost`. Will be resolved by upstream PR: emscripten-core/emscripten#24593
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 18, 2025
…honGH-135634) Emscripten currently `gethostbyname_r()` returns an incorrect IP address for `localhost`. Will be resolved by upstream PR: emscripten-core/emscripten#24593 (cherry picked from commit 2a49c54) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
freakboy3742
pushed a commit
to python/cpython
that referenced
this pull request
Jun 18, 2025
…-135634) (#135651) Emscripten currently `gethostbyname_r()` returns an incorrect IP address for `localhost`. Will be resolved by upstream PR: emscripten-core/emscripten#24593 (cherry picked from commit 2a49c54) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causing a failure in the Python test suite.