Remove Arguments from jsdoc

[sbc100]

Looks like this was originally added in #10525.

Perhaps closure compiler used to have a distinct type for arguments builtin in JS? I can't see any mention of it in closure compiler documentation today though.

Fixes: #24579

[RReverser]

Perhaps closure compiler used to have a distinct type for arguments builtin in JS?

It would make sense, since arguments object is historically special and isn't actually an array (eg it lacks all the array methods, and you would want typechecker like Closure to catch you using them by accident).

[RReverser]

I can't see any mention of it in closure compiler documentation today though.

Not documentation, but here's the declaration of extern: https://github.com/google/closure-compiler/blob/71975c675e458b9bfed8fe0e737d388a82b71918/externs/es3.js#L230

[sbc100]

Perhaps closure compiler used to have a distinct type for arguments builtin in JS?

It would make sense, since arguments object is historically special and isn't actually an array (eg it lacks all the array methods, and you would want typechecker like Closure to catch you using them by accident).

But we don't use arguments any more in the code base right? So this should no longer be needed. Especially since it seems to confuse TSC.

[RReverser]

But we don't use arguments any more in the code base right?

I don't know, haven't checked, just saw the PR description and wanted to clarify they're not the same. If it's not used, go for it of course.

[sbc100]

But we don't use arguments any more in the code base right?

I don't know, haven't checked, just saw the PR description and wanted to clarify they're not the same. If it's not used, go for it of course.

I'm pretty sure it was needed for the cwrap implemention which was converted to the rest operator in #21331

[juj]

lgtm