Fix makeRemovedFSAssert() resolved path
#24567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
force-pushed
the
resolve-actual-lib
branch
3 times, most recently
from
e508d75 to
9fcae01
Compare
sbc100
reviewed
Jun 13, 2025
adamscott
force-pushed
the
resolve-actual-lib
branch
from
9fcae01 to
88dd214
Compare
sbc100
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
path.resolve()resolves using the CWD (which is usually the target project path) instead of the directory of the script itself.The current behavior causes issues with the Closure compiler, as stubs are erroneously created instead of being skipped in
src/shell.js. Closure then complains that variables are declared twice.The issue was caused by #23348 which changed the logic of the search.