Add support for -fcoverage-mapping support #24160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enought make it work up until llvm-cov tries to read the named data sections in the binary and can't find them. For this final part to work we probably need to switch the object format to using multiple code and data sections: WebAssembly/tool-conventions#138 Not sure if its worth submitting this part in isolation without a fully working solution? See emscripten-core#13046
# Conflicts: # emcc.py # tests/test_core.py # tools/shared.py # tools/system_libs.py
sbc100
reviewed
Apr 21, 2025
arsnyder16
force-pushed
the
arsnyder16-fcoverage
branch
from
f1a383d to
10bbd61
Compare
arsnyder16
commented
Apr 23, 2025
# Conflicts: # test/test_core.py
…emscripten into arsnyder16-fcoverage
arsnyder16
force-pushed
the
arsnyder16-fcoverage
branch
from
7c189ff to
56a1d3a
Compare
…emscripten into arsnyder16-fcoverage
|
@sbc100 I think this is ready, not sure why some of the test failures, seems unrelated. |
sbc100
approved these changes
Jun 16, 2025
sbc100
reviewed
Jun 16, 2025
sbc100
reviewed
Jun 16, 2025
Added. Let me know if there is anything else i should specifically call out |
sbc100
reviewed
Jun 16, 2025
sbc100
approved these changes
Jun 16, 2025
|
Just to confirm, the new files are taken from the emscripten-libs-20 branch in llvm? |
Correct, i used |
sbc100
added a commit
that referenced
this pull request
Jun 16, 2025
It looks like without this the fallback functions are not actually thread safe: https://github.com/llvm/llvm-project/blob/63b80dd01dafc92104ee43e4f0f5296d644c25ec/compiler-rt/lib/profile/InstrProfilingUtil.c#L102-L119 Followup to #24160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main introduction is porting
llvm-project/compiler_rt/lib/profileinto system/lib/compiler_rt/lib/profileRelated
#13072
llvm/llvm-project#111332
No modifications were required for what was ported. llvm-cov worked fine for me with simple project.
-gis required to produce a properly instrumented binaryerror: failed to load coverage: 'my.wasm': no coverage data found