[test] Remove manually_trigger_reftest option. NFC
#22665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
manually_trigger_reftest
branch
2 times, most recently
from
673b9d5 to
dba72ec
Compare
kripken
approved these changes
Oct 1, 2024
| @@ -2215,6 +2213,7 @@ def make_reftest(self, expected, manually_trigger=False): | |||
| function doReftest() { | |||
| if (doReftest.done) return; | |||
| doReftest.done = true; | |||
| console.log('doReftest'); | |||
There was a problem hiding this comment.
I'm happy to leave this.. seems useful for debugging.
This option was only being used by 5 tests. These 5 tests are all for SDL_image and they seem to work perfectly fine with automatic reftest which happens when the application is done
sbc100
force-pushed
the
manually_trigger_reftest
branch
from
dba72ec to
142f070
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 2, 2024
In emscripten-core#22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 2, 2024
In emscripten-core#22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 2, 2024
In emscripten-core#22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 2, 2024
In emscripten-core#22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 2, 2024
In emscripten-core#22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
sbc100
added a commit
that referenced
this pull request
Oct 2, 2024
…22672) In #22665 I removed the manually_trigger_reftest. However this resulted in racey behaviour in some tests. It turns out that running `doReftest` during `postRun` was working, but only because `doReftest` itself was doing async work, thus delaying the actual capture of the canvas bits. This change re-instates the behaviour but without the need to test setting in python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was only being used by 5 tests. These 5 tests are all for SDL_image and they seem to work perfectly fine with automatic reftest which happens when the application is done