[Wasm64] futex fixes #20116
Merged
[Wasm64] futex fixes #20116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sbc100 do you think you can review, merge and make a new release with these changes? I'll update the other PR with tests once spec/V8 change with u32->i32 lands |
sbc100
approved these changes
Aug 24, 2023
Member
|
Browser test failure here is identical on firefox and chrome, so it might be real? |
auto-merge was automatically disabled
August 24, 2023 19:14
Head branch was pushed to by a user without write access
Contributor
Author
Yeah, my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #19959 that can be merged now, since memory index support is already merged.