Remove LLD_REPORT_UNDEFINED setting #18342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_lld_report_undefined
branch
2 times, most recently
from
085718e to
b16fb44
Compare
sbc100
changed the title
This setting became the default in #16003. There is no reason to keep it around anymore and we have has no issues reported in the last 3 months (4 releases).
sbc100
force-pushed
the
remove_lld_report_undefined
branch
from
b16fb44 to
2d3b509
Compare
|
The key think that this change unlocks is the ability to remove deps_info.py and move the information into the library files, (similar to #15982). |
kripken
reviewed
Feb 24, 2023
kripken
approved these changes
Feb 24, 2023
Co-authored-by: Alon Zakai <azakai@google.com>
sbc100
force-pushed
the
remove_lld_report_undefined
branch
from
a99b680 to
ceefdd3
Compare
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
This setting became the default in emscripten-core#16003. There is no reason to keep it around anymore and we have has no issues reported in the last 3 months (4 releases).
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
This setting became the default in emscripten-core#16003. There is no reason to keep it around anymore and we have has no issues reported in the last 3 months (4 releases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting became the default in #16003. There is no reason to keep
it around anymore and we have has no issues reported in the last 3
months (4 releases).