Factor out runEmAsmFunction. NFC
#18218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
runEmAsmFunction
branch
from
bb6eafd to
80f838d
Compare
sbc100
force-pushed
the
runEmAsmFunction
branch
from
80f838d to
4203740
Compare
kripken
approved these changes
Nov 16, 2022
sbc100
force-pushed
the
runEmAsmFunction
branch
from
4203740 to
276a0ea
Compare
This is the polymorphic JS function that is used to implement all of the `emscripten_asm_const*` functions. Also, rename readAsmConstArgs -> readEmAsmArgs. Using the EmAsm name rather than AsmConst name makes more sense since `asm` on its own is an overloaded term, and there is nothing `const` about these arguments.
sbc100
force-pushed
the
runEmAsmFunction
branch
from
276a0ea to
5b39e1a
Compare
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Dec 9, 2024
This commit changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs`
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Feb 13, 2025
This commit changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs`
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Feb 21, 2025
It fixes emscripten_audio_worklet_post_function_sig, which was previously not worked, and enhances test to cover all emscripten_audio_worklet_post_function_*. In order to fix, it changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs` enhance the test for cover all emscripten_audio_worklet_post_function_*
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Feb 21, 2025
It fixes emscripten_audio_worklet_post_function_sig, which was previously not worked, and enhances test to cover all emscripten_audio_worklet_post_function_*. In order to fix, it changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs` enhance the test for cover all emscripten_audio_worklet_post_function_*
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Feb 21, 2025
It fixes emscripten_audio_worklet_post_function_sig, which was previously not worked, and enhances test to cover all emscripten_audio_worklet_post_function_*. In order to fix, it changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs` enhance the test for cover all emscripten_audio_worklet_post_function_*
mighty1231
added a commit
to mighty1231/emscripten
that referenced
this pull request
Feb 25, 2025
It fixes emscripten_audio_worklet_post_function_sig, which was previously not worked, and enhances test to cover all emscripten_audio_worklet_post_function_*. In order to fix, it changes the old term `readAsmConstArgs` to the new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218 Background history: 1. emscripten-core#16449 proposed, introducing AudioWorklet earlier 2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs 3. emscripten-core#18218 merged earlier 4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs` enhance the test for cover all emscripten_audio_worklet_post_function_*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the polymorphic JS function that is used to implement all of the
emscripten_asm_const*functions.Also, rename
readAsmConstArgs->readEmAsmArgs. Using theEmAsmname rather thanAsmConstname makes more sense sinceasmon its own is an overloaded term, and there is nothingconstabout these arguments.