Skip to content

Remove redundant call to pthread_testcancel. NFC. #15657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

Remove redundant call to pthread_testcancel. NFC. #15657

merged 1 commit into from
Nov 30, 2021

Conversation

kleisauke
Copy link
Collaborator

This was introduced in commit d2bb705 (which was based on musl
1.0.5), but when musl was updated to 1.1.15 (commit 31cf2bb),
it ends up calling pthread_testcancel twice.

Split from PR #15603.

@kleisauke
Remove redundant call to pthread_testcancel. NFC.
de5c660 
This was introduced in commit d2bb705 (which was based on musl
1.0.5), but when musl was updated to 1.1.15 (commit 31cf2bb),
it ends up calling pthread_testcancel twice.
This was referenced Nov 30, 2021
Merged
Merged
@sbc100 sbc100 merged commit 9fc637b into emscripten-core:main Nov 30, 2021
@kleisauke kleisauke deleted the remove-redunant-testcancel branch November 30, 2021 14:59
mmarczell-graphisoft pushed a commit to GRAPHISOFT/emscripten that referenced this pull request Jan 5, 2022
@kleisauke @mmarczell-graphisoft
Remove redundant call to pthread_testcancel. NFC. (emscripten-core#15657
528e4c4 
)

This was introduced in commit d2bb705 (which was based on musl
1.0.5), but when musl was updated to 1.1.15 (commit 31cf2bb),
it ends up calling pthread_testcancel twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleisauke @sbc100