Remove legacy __sys_exit syscall. NFC #14463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was replaced by the WASI `proc_exit` syscall a while back.
kripken
approved these changes
Jun 16, 2021
| #if SANITIZER_FREEBSD || SANITIZER_SOLARIS | ||
| #if SANITIZER_EMSCRIPTEN | ||
| __wasi_proc_exit(exitcode); | ||
| #elif SANITIZER_FREEBSD || SANITIZER_SOLARIS | ||
| internal_syscall(SYSCALL(exit), exitcode); |
There was a problem hiding this comment.
I guess it's unlikely that we have users that call syscalls like this, but what do you think about a changelog mention of this?
There was a problem hiding this comment.
We have not generally made changelog entries for syscall naming changes as far as I am aware.
There was a problem hiding this comment.
I guess back in v1.39.12 I wrote: Rename syscalls to have meaningful names (#10750). .. but that was after renaming all of them at once :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was replaced by the WASI
proc_exitsyscall a whileback.