Deprecate unused --llvm-opts command line argument #13750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
deprecate_llvm_opts
branch
from
c7a7f58 to
65834cb
Compare
sbc100
changed the title
This option was already essentially ignored is the value of `options.llvm_opts` was written but never read by the compiler driver. The last use of this option was removed back in #11967 but this went unnoticed.
sbc100
force-pushed
the
deprecate_llvm_opts
branch
from
65834cb to
0d6687c
Compare
kripken
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was already essentially ignored is the value of
options.llvm_optswas written but never read by the compiler driver.The last use of this option was removed back in #11967 but this went
unnoticed.