-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add initial support -fcoverage-mapping support #13072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is enought make it work up until llvm-cov tries to read the named data sections in the binary and can't find them. For this final part to work we probably need to switch the object format to using multiple code and data sections: WebAssembly/tool-conventions#138 Not sure if its worth submitting this part in isolation without a fully working solution? See #13046
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
wasm-ld: error: /var/folders/61/x35v93n50_5g1dfjrtprr2dw0000gn/T/emscripten_temp_xjrzk63_/demo_0.o: undefined symbol: __llvm_profile_runtime need help, emcc seems not support -fcoverage-mapping? |
No, emcc doesn't support this yet. This PR would be a start, but more work would be needed. |
Any news on this? |
@sbc100 Any update here? Do the original shortcoming still exists? Is there value in including without support for named data sections? Currently going to look at getting |
No update I'm afraid. Let is know if you manage to get stuff working. |
Main introduction is porting `llvm-project/compiler_rt/lib/profile` `into system/lib/compiler_rt/lib/profile` Related #13072 llvm/llvm-project#111332 No modifications were required for what was ported. llvm-cov worked fine for me with simple project. * `-g` is required to produce a properly instrumented binary `error: failed to load coverage: 'my.wasm': no coverage data found`
Closing in favor of #13072 |
This is enought make it work up until llvm-cov tries to read the
named data sections in the binary and can't find them. For this
final part to work we probably need to switch the object format to
using multiple code and data sections:
WebAssembly/tool-conventions#138
Not sure if its worth submitting this part in isolation without
a fully working solution?
See #13046