Integrate posixtestsuite for pthread testing #12923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
add_posixtestsuite
branch
3 times, most recently
from
202dd9c to
55c419f
Compare
sbc100
added a commit
that referenced
this pull request
Nov 30, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
added a commit
that referenced
this pull request
Nov 30, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
added a commit
that referenced
this pull request
Dec 1, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
force-pushed
the
add_posixtestsuite
branch
from
69b1d2c to
286a86d
Compare
kripken
approved these changes
Dec 1, 2020
sbc100
added a commit
that referenced
this pull request
Dec 2, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
added a commit
that referenced
this pull request
Dec 2, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
force-pushed
the
add_posixtestsuite
branch
2 times, most recently
from
c8ea7fd to
63b1dd1
Compare
sbc100
added a commit
that referenced
this pull request
Dec 2, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
added a commit
that referenced
this pull request
Dec 2, 2020
This means that tests don't necessarily need to call REPORT_RESULT. I'm going to be taking advantage of this in #12923. Also, don't initialize EXIT_STATUS to zero, but leave it as undefined. It seems useful to be able to tell the diference between a program that exits with a zero status and one that has not in fact exited yet.
sbc100
force-pushed
the
add_posixtestsuite
branch
2 times, most recently
from
9a4e41b to
83114d4
Compare
This change adds posixtestsuite as a git submodule (in tests/third_party). It also adds a new test suite that auto-populates based on the files in `posixtestsuite/conformance/interfaces/pthread_*` The submodule is optional in that the testsuite simply remains empty if it is not found.
sbc100
force-pushed
the
add_posixtestsuite
branch
from
83114d4 to
4856f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds posixtestsuite as a git submodule (in tests/third_party).
It also adds a new test suite that auto-populates based on the files
in
posixtestsuite/conformance/interfaces/pthread_*The submodule is optional in that the testsuite simply remains empty
if it is not found.
For now we just run a single one of these test under node in CI to verify
that basic concept works.