Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using symlinks for shell script launchers #10921

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 14, 2020

For windows users that use MINGW the shell scripts as still useful
(preferable to the .bat scripts) but they don't support symlink.

Write little script for managing these entry points.

@sbc100 sbc100 changed the title Stop using symbolic for shell script launchers Stop using symlinks for shell script launchers Apr 14, 2020
For windows users that use MINGW the shell scripts as still useful
(preferable to the .bat scripts) but they don't support symlink.

Add a little script for managing these entry points.
This change was mostly mechanically created by running this script.
@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 14, 2020

This change was mostly mechanically created by running the new tools/create_entry_points.py script.

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 14, 2020

Tested on windows cmd and MINGW shell.

@sbc100 sbc100 requested a review from kripken April 14, 2020 23:09
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good but am not an expert on this stuff...

@sbc100 sbc100 merged commit 1c6e796 into master Apr 15, 2020
@sbc100 sbc100 deleted the launcher_scripts branch April 15, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants