Fix more Closure warnings #10525
Merged
Fix more Closure warnings #10525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Feb 21, 2020
| @@ -1735,7 +1742,11 @@ for (var x in SyscallsLibrary) { | |||
| } | |||
| #if SYSCALL_DEBUG | |||
| if (which && t.indexOf(', varargs') != -1) { | |||
| post += 'SYSCALLS.varargs = undefined;\n'; | |||
| if (canThrow) { | |||
| post += 'finally { SYSCALLS.varargs = undefined; }\n'; | |||
There was a problem hiding this comment.
do we always emit a try if SYSCALL_DEBUG? (even if it's nothrow etc.?)
There was a problem hiding this comment.
No, only if canThrow is enabled.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 16, 2025
Looks like this was originally added in emscripten-core#10525. Perhaps closure compiler used to have a distinct type for `arguments` builtin in JS? I can't see any mention of it in closure compiler documentation today though. Fixes: emscripten-core#24579
sbc100
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting closer to Closure clean.