Skip to content

Commit c0711b2

Browse files
authored
Re-enable wasm64+pthreads browser tests. NFC (#20304)
1 parent c41f659 commit c0711b2

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

test/test_browser.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4754,9 +4754,7 @@ def test_fetch_cached_xhr(self):
47544754

47554755
# Tests that response headers get set on emscripten_fetch_t values.
47564756
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4757-
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4758-
# @also_with_wasm2js_or_wasm64
4759-
@also_with_wasm2js
4757+
@also_with_wasm2js_or_wasm64
47604758
@requires_threads
47614759
def test_fetch_response_headers(self):
47624760
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -4789,9 +4787,7 @@ def test_fetch_xhr_abort(self):
47894787
# Tests emscripten_fetch() usage in synchronous mode when used from the main
47904788
# thread proxied to a Worker with -sPROXY_TO_PTHREAD option.
47914789
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4792-
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4793-
# @also_with_wasm2js_or_wasm64
4794-
@also_with_wasm2js
4790+
@also_with_wasm2js_or_wasm64
47954791
@requires_threads
47964792
def test_fetch_sync_xhr(self):
47974793
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -4800,8 +4796,7 @@ def test_fetch_sync_xhr(self):
48004796
# Tests emscripten_fetch() usage when user passes none of the main 3 flags (append/replace/no_download).
48014797
# In that case, in append is implicitly understood.
48024798
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
4803-
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
4804-
# @also_with_wasm64
4799+
@also_with_wasm64
48054800
@requires_threads
48064801
def test_fetch_implicit_append(self):
48074802
shutil.copyfile(test_file('gears.png'), 'gears.png')
@@ -5634,8 +5629,7 @@ def test_full_js_library_strict(self):
56345629
# Tests the AudioWorklet demo
56355630
@parameterized({
56365631
'': ([],),
5637-
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
5638-
# 'memory64': (['-sMEMORY64', '-Wno-experimental'],),
5632+
'memory64': (['-sMEMORY64', '-Wno-experimental'],),
56395633
'with_fs': (['--preload-file', test_file('hello_world.c') + '@/'],),
56405634
'closure': (['--closure', '1', '-Oz'],),
56415635
'asyncify': (['-sASYNCIFY'],),

0 commit comments

Comments
 (0)