Feedback from #24426 (#24434)

Author: sbc100

test/test_other.py

@@ -1094,6 +1094,7 @@ def test_pkg_config_packages(self):
   @requires_pkg_config
   @crossplatform
   def test_pkg_config_ports(self):
+    # Use bullet here because it is part of the MINIMAL set of tasks in embuilder.
     self.run_process([EMBUILDER, 'build', 'bullet'])
     out = self.run_process([emmake, 'pkg-config', '--list-all'], stdout=PIPE).stdout
     self.assertContained('bullet', out)

tools/ports/giflib.py

@@ -17,7 +17,7 @@ def get(ports, settings, shared):
   def create(final):
     source_path = ports.get_dir('giflib', f'giflib-{VERSION}')
     ports.install_headers(source_path)
-    ports.make_pkg_config('giffix', VERSION, '-sUSE_GIFLIB')
+    ports.make_pkg_config('giflib', VERSION, '-sUSE_GIFLIB')
     exclude_files = [
       'giffix.c', 'gifecho.c', 'giffilter.c', 'gifcolor.c', 'gifecho.c', 'gifinto.c',
       'gifsponge.c', 'gif2rgb.c', 'gifbg.c', 'gifbuild.c', 'gifclrmp.c', 'gifhisto.c',

tools/ports/icu.py

@@ -64,6 +64,7 @@ def create_libicu_common(lib_output):
     prepare_build()
     lib_src = os.path.join(icu_source_path, 'common')
     ports.install_headers(os.path.join(lib_src, 'unicode'), target='unicode')
+    ports.make_pkg_config('ici', VERSION, '-sUSE_ICU')
     build_lib(lib_output, lib_src, [], ['-DU_COMMON_IMPLEMENTATION=1'])
 
   # creator for libicu_stubdata

tools/ports/sdl2.py

@@ -6,9 +6,9 @@
 import os
 
 VERSION = '2.32.0'
-TAG = 'release-2.32.0'
+TAG = f'release-{VERSION}'
 HASH = 'd3e4ce9784152aa1194c4f2d2399829f3b01a652915afc6ddaec334068bf95d850edcb43b1a951e0202fc2ecaafc1f58e538ca39b9b16d3fdfe412af0b6aebb0'
-SUBDIR = 'SDL-' + TAG
+SUBDIR = f'SDL-{TAG}'
 
 variants = {'sdl2-mt': {'PTHREADS': 1}}
 

tools/ports/sdl3.py

@@ -10,9 +10,9 @@
 from tools import diagnostics
 
 VERSION = '3.2.4'
-TAG = 'release-3.2.4'
+TAG = f'release-{VERSION}'
 HASH = 'c26a8afeec481e3ae3b435eec405d9f99d78752ebf5118963cd56728ceff23772769f5291df581329488da7489034e835301b08d61a42c811764e24b3542a4c2'
-SUBDIR = 'SDL-' + TAG
+SUBDIR = f'SDL-{TAG}'
 
 variants = {'sdl3-mt': {'PTHREADS': 1}}