Modify musl errno messages to match llvm-libc

Author: google-yfyang

system/lib/libc/musl/src/errno/__strerror.h

@@ -2,8 +2,12 @@
  * This file is included multiple times to declare and define a structure
  * with these messages, and then to define a lookup table translating
  * error codes to offsets of corresponding fields in the structure. */
-
+#if defined(__EMSCRIPTEN__)
+// This is intended to match the errno in llvm-libc.
+E(0,            "Success")
+#else
 E(0,            "No error information")
+#endif
 
 E(EILSEQ,       "Illegal byte sequence")
 E(EDOM,         "Domain error")
@@ -16,7 +20,12 @@ E(ENOENT,       "No such file or directory")
 E(ESRCH,        "No such process")
 E(EEXIST,       "File exists")
 
+#if defined(__EMSCRIPTEN__)
+// This is intended to match the errno in llvm-libc.
+E(EOVERFLOW,    "Value too large for defined data type")
+#else
 E(EOVERFLOW,    "Value too large for data type")
+#endif
 E(ENOSPC,       "No space left on device")
 E(ENOMEM,       "Out of memory")
 

system/lib/llvm-libc/src/__support/StringUtil/tables/posix_errors.h

@@ -63,12 +63,7 @@ LIBC_INLINE_VAR constexpr MsgTable<76> POSIX_ERRORS = {
     MsgMapping(EPROTO, "Protocol error"),
     MsgMapping(EMULTIHOP, "Multihop attempted"),
     MsgMapping(EBADMSG, "Bad message"),
-#ifdef __EMSCRIPTEN__
-    // For now, match the musl string
-    MsgMapping(EOVERFLOW, "Value too large for data type"),
-#else
     MsgMapping(EOVERFLOW, "Value too large for defined data type"),
-#endif
     MsgMapping(ENOTSOCK, "Socket operation on non-socket"),
     MsgMapping(EDESTADDRREQ, "Destination address required"),
     MsgMapping(EMSGSIZE, "Message too long"),

system/lib/llvm-libc/src/__support/StringUtil/tables/stdc_errors.h

@@ -16,12 +16,7 @@
 namespace LIBC_NAMESPACE_DECL {
 
 LIBC_INLINE_VAR constexpr const MsgTable<4> STDC_ERRORS = {
-#ifdef __EMSCRIPTEN__
-    // For now, match the musl name for errno 0.
-    MsgMapping(0, "No error information"),
-#else
     MsgMapping(0, "Success"),
-#endif
     MsgMapping(EDOM, "Numerical argument out of domain"),
     MsgMapping(ERANGE, "Numerical result out of range"),
     MsgMapping(EILSEQ, "Invalid or incomplete multibyte or wide character"),

test/fcntl/test_fcntl_misc.out

@@ -8,5 +8,5 @@ st_size: 10
 
 posix_fallocate 3: Invalid argument
 posix_fallocate 4: Invalid argument
-posix_fallocate 5: Value too large for data type
-posix_fallocate 6: Value too large for data type
+posix_fallocate 5: Value too large for defined data type
+posix_fallocate 6: Value too large for defined data type

test/unistd/curdir.out

@@ -1,5 +1,5 @@
 getcwd: /
-errno: No error information
+errno: Success
 
 chdir(file): -1
 errno: Not a directory
@@ -11,16 +11,16 @@ chdir(device): -1
 errno: Not a directory
 
 chdir(folder): 0
-errno: No error information
+errno: Success
 getcwd: /folder
 
 chdir(nonexistent): -1
 errno: No such file or directory
 
 chdir(link): 0
-errno: No error information
+errno: Success
 getcwd: /folder
 
 fchdir(/): 0
-errno: No error information
+errno: Success
 getcwd: /

test/unistd/dup.out

@@ -1,13 +1,13 @@
 DUP
-errno: No error information
+errno: Success
 f: 1
 f2,f3: 1
 close(f1): 0
 close(f2): 0
 close(f3): 0
 
 DUP2
-errno: No error information
+errno: Success
 f: 1
 f2,f3: 1
 close(f1): 0

test/unistd/links.out

@@ -1,5 +1,5 @@
 readlink: 'link'
-errno: No error information
+errno: Success
 
 readlink: 'file'
 errno: Invalid argument

test/unistd/test_unistd_write_broken_link.out

@@ -1,6 +1,6 @@
 link result: 0
-source_fd: 3, errno: 0 No error information
-target_fd: 3, errno: 0 No error information
+source_fd: 3, errno: 0 Success
+target_fd: 3, errno: 0 Success
 buf: 'abc'
-target_fd: 3, errno: 0 No error information
+target_fd: 3, errno: 0 Success
 buf: 'abc'

test/unistd/truncate.out

@@ -1,23 +1,23 @@
 st_size: 6
 
 ftruncate(10): 0
-errno: No error information
+errno: Success
 st_size: 10
 
 ftruncate(4): 0
-errno: No error information
+errno: Success
 st_size: 4
 
 ftruncate(-1): -1
 errno: Invalid argument
 st_size: 4
 
 truncate(2): 0
-errno: No error information
+errno: Success
 st_size: 2
 
 open(O_TRUNC)
-errno: No error information
+errno: Success
 st_size: 0
 
 truncate(readonly, 2): -1

test/wasmfs/wasmfs_chdir.out

@@ -5,7 +5,7 @@ Current working dir: /
 Current working dir: /working/test
 Errno: No such file or directory
 Current working dir is still: /working/test
-Errno: No error information
+Errno: Success
 Current working dir is now: /working
 Errno: No such file or directory
 Current working dir is still: /working