Fix lost values in Iterator which key is duplicated

Author: emonkak

src/Enumerable.php

@@ -460,7 +460,7 @@ public function shuffle()
     {
         return $this->newLazyCollection(function() {
             $xs = $this->getSource();
-            $array = Iterators::toArray($xs);
+            $array = Iterators::toList($xs);
             shuffle($array);
             return $array;
         });
@@ -470,7 +470,7 @@ public function sample($n = null)
     {
         $xs = $this->getSource();
         if ($n === null) {
-            $array = Iterators::toArray($xs);
+            $array = Iterators::toList($xs);
             if (empty($array)) {
                 return null;
             }
@@ -646,15 +646,15 @@ public function reverse()
     {
         return $this->newLazyCollection(function() {
             $xs = $this->getSource();
-            return array_reverse(Iterators::toArray($xs));
+            return array_reverse(Iterators::toList($xs));
         });
     }
 
     public function sort($comparer = null)
     {
         $comparer = $this->resolveComparer($comparer);
         return $this->newLazyCollection(function() use ($comparer) {
-            $xs = Iterators::toArray($this->getSource());
+            $xs = Iterators::toList($this->getSource());
             usort($xs, $comparer);
             return $xs;
         });
@@ -693,7 +693,7 @@ public function object($values = null)
 
     public function indexOf($value, $isSorted = 0)
     {
-        $xs = Iterators::toArray($this->getSource());
+        $xs = Iterators::toList($this->getSource());
 
         if ($isSorted === true) {
             $i = $this->newCollection($xs)->sortedIndex($value);
@@ -713,7 +713,7 @@ public function indexOf($value, $isSorted = 0)
 
     public function lastIndexOf($x, $fromIndex = null)
     {
-        $xs = Iterators::toArray($this->getSource());
+        $xs = Iterators::toList($this->getSource());
         $l = count($xs);
         $i = $fromIndex !== null ? min($l, $fromIndex) : $l;
 
@@ -728,7 +728,7 @@ public function lastIndexOf($x, $fromIndex = null)
 
     public function sortedIndex($value, $selector = null)
     {
-        $xs = Iterators::toArray($this->getSource());
+        $xs = Iterators::toList($this->getSource());
         $selector = $this->resolveSelector($selector);
         $value = $selector($value, null, []);
 

tests/AbstractCollectionTest.php

@@ -1094,6 +1094,10 @@ public function testFlatten($factory)
         $result = $factory($list)->flatten(true)->toList();
         $shouldBe = [1, 2, 3, [[[4]]]];
         $this->assertSame($shouldBe, $result, 'can shallowly flatten nested arrays');
+
+        $result = $factory($list)->flatten()->reverse()->toList();
+        $shouldBe = [4, 3, 2, 1];
+        $this->assertSame($shouldBe, $result, 'can flatten nested arrays');
     }
 
     /**