Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when repo name contains number or '.' root pipeline is always ignored #87

Open
Joshua-Igoni opened this issue Jul 5, 2023 · 7 comments
Assignees
Labels
bug An issue with the system 🐛.

Comments

@Joshua-Igoni
Copy link

I had two repos that i testing with this orb. one had a simple name "test-repo" the other had name like "test-repo-2.0"

I set up basically two pipelines in each of them, the pipelines where very identical... for the first repo execution was fine, but for the second one with the number and "." the root pipeline was always ignored.

example pipeline configs to reproduce as follows:

app.yml(root-config pipeline)

 version: 2.1

executors:
   my_executorl:
    machine:
      image: ubuntu-2204:2022.04.2
      docker_layer_caching: true


#/**************************************************************************
#******************    JOBS CONFIGURATION AND SPECIFICATION   *************#
#**************************************************************************/


jobs:
  Unit_test:
    machine:
      image: ubuntu-2204:2022.04.2
      docker_layer_caching: true
    steps:
      - run:
          name: is this root?
          command: | 
            echo "this is root"

workflows:
  Base_tests:
    jobs:
      - Unit_test

the second pipeline that is listening for changes in a different directory
test.yml

version: 2.1

executors:
  my_executor:
    machine:
      image: ubuntu-2204:2022.04.2
      docker_layer_caching: true


#/**************************************************************************
#******************    JOBS CONFIGURATION AND SPECIFICATION   *************#
#**************************************************************************/


jobs:
  Unit_test:
    machine:
      image: ubuntu-2204:2022.04.2
      docker_layer_caching: true
    steps:
      - run:
          name: is it working
          command: | 
            echo "ok we are good"

workflows:
  Base_tests:
    jobs:
      - Unit_test

then the config for dynamic/continuation
config.yml

#/**************************************************************************
#******************    TOP LEVEL CONFIGURATION      ***********************#
#**************************************************************************/

version: 2.1

setup: true

orbs:
  dynamic: bjd2385/dynamic-continuation@3.6.7

workflows:
    test-workflow:
      jobs:
        - dynamic/continue:
            context: circleci-api
            default-branch: develop
            auto-detect: true
            root-config: app
            modules: |
              /
              /test

as explained earlier, this works fine for repos containing no number and '.' in their name, but ignores root config pipeline when the repo name has a number and/or . in the name

@emmeowzing
Copy link
Owner

Hmm, can you upgrade that to v3.6.12 (latest) and let me know if you have the same issue? I'll dig into this a bit more later this morning.

Side note, also: there's no need to list modules if auto-detect is enabled, which it is by default. The modules list is ignored.

@emmeowzing emmeowzing added the bug An issue with the system 🐛. label Jul 5, 2023
@emmeowzing emmeowzing self-assigned this Jul 5, 2023
@Joshua-Igoni
Copy link
Author

i just tested with version 3.6.12, the issue persists

@emmeowzing
Copy link
Owner

Okay, I'll dig into this later today. Thank you for testing with latest, there were minor changes to the auto-detect regex so I wanted to make sure we were debugging with that.

@Joshua-Igoni
Copy link
Author

Hi, any update on this? :)

@emmeowzing
Copy link
Owner

Oh my! I will take a look this afternoon, then, and try to reproduce. sorry I had a lot of stuff come up with work the past two weeks

@Joshua-Igoni
Copy link
Author

its alright... :)

@emmeowzing
Copy link
Owner

emmeowzing commented Aug 11, 2023

@Joshua-Igoni again, apologies for this thread :P trying to reproduce this over in these two repos ~

https://github.com/emmeowzing/test-repo
https://github.com/emmeowzing/test-repo-2.0/pull/2

could I ask, what's the list of commands look like in the dynamic/continue-job? Do they stop short of the continuation, by chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the system 🐛.
Projects
None yet
Development

No branches or pull requests

2 participants