Skip to content

Commit 76140c0

Browse files
committed
Remove unuse code from TestClientConfigurationConfigurable.java
1 parent 1ec6618 commit 76140c0

File tree

1 file changed

+3
-37
lines changed

1 file changed

+3
-37
lines changed

embulk-input-s3/src/test/java/org/embulk/input/s3/TestClientConfigurationConfigurable.java

Lines changed: 3 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -5,72 +5,38 @@
55
import org.embulk.EmbulkTestRuntime;
66
import org.embulk.config.ConfigException;
77
import org.embulk.config.ConfigSource;
8-
import org.embulk.config.TaskReport;
9-
import org.embulk.config.TaskSource;
108
import org.embulk.spi.Exec;
11-
import org.embulk.spi.FileInputRunner;
12-
import org.embulk.spi.InputPlugin;
13-
import org.embulk.spi.Schema;
14-
import org.embulk.spi.TestPageBuilderReader;
159
import org.junit.Before;
16-
import org.junit.BeforeClass;
1710
import org.junit.Rule;
1811
import org.junit.Test;
1912

2013
import java.security.NoSuchAlgorithmException;
2114
import java.security.SecureRandom;
22-
import java.util.List;
2315

2416
import static org.embulk.input.s3.TestS3FileInputPlugin.parserConfig;
2517
import static org.embulk.input.s3.TestS3FileInputPlugin.schemaConfig;
26-
import static org.junit.Assert.*;
27-
import static org.junit.Assume.assumeNotNull;
18+
import static org.junit.Assert.assertEquals;
2819

2920
/**
3021
* Created by takahiro.nakayama on 3/30/16.
3122
*/
3223
public class TestClientConfigurationConfigurable
3324
{
34-
private static String EMBULK_S3_TEST_BUCKET;
35-
private static String EMBULK_S3_TEST_ACCESS_KEY_ID;
36-
private static String EMBULK_S3_TEST_SECRET_ACCESS_KEY;
37-
private static final String EMBULK_S3_TEST_PATH_PREFIX = "embulk_input_s3_test";
38-
39-
/*
40-
* This test case requires environment variables:
41-
* EMBULK_S3_TEST_BUCKET
42-
* EMBULK_S3_TEST_ACCESS_KEY_ID
43-
* EMBULK_S3_TEST_SECRET_ACCESS_KEY
44-
* If the variables not set, the test case is skipped.
45-
*/
46-
@BeforeClass
47-
public static void initializeConstantVariables()
48-
{
49-
EMBULK_S3_TEST_BUCKET = System.getenv("EMBULK_S3_TEST_BUCKET");
50-
EMBULK_S3_TEST_ACCESS_KEY_ID = System.getenv("EMBULK_S3_TEST_ACCESS_KEY_ID");
51-
EMBULK_S3_TEST_SECRET_ACCESS_KEY = System.getenv("EMBULK_S3_TEST_SECRET_ACCESS_KEY");
52-
assumeNotNull(EMBULK_S3_TEST_BUCKET, EMBULK_S3_TEST_ACCESS_KEY_ID, EMBULK_S3_TEST_SECRET_ACCESS_KEY);
53-
}
54-
5525
@Rule
5626
public EmbulkTestRuntime runtime = new EmbulkTestRuntime();
5727

5828
private S3FileInputPlugin plugin;
5929
private ConfigSource config;
60-
private FileInputRunner runner;
61-
private TestPageBuilderReader.MockPageOutput output;
6230

6331
@Before
6432
public void createResources()
6533
{
6634
plugin = new S3FileInputPlugin();
6735
config = runtime.getExec().newConfigSource()
6836
.set("type", "s3")
69-
.set("bucket", EMBULK_S3_TEST_BUCKET)
70-
.set("path_prefix", EMBULK_S3_TEST_PATH_PREFIX)
37+
.set("bucket", "dummy")
38+
.set("path_prefix", "dummy")
7139
.set("parser", parserConfig(schemaConfig()));
72-
runner = new FileInputRunner(runtime.getInstance(S3FileInputPlugin.class));
73-
output = new TestPageBuilderReader.MockPageOutput();
7440
}
7541

7642
@Test

0 commit comments

Comments
 (0)