Skip to content
This repository was archived by the owner on Mar 22, 2019. It is now read-only.

Custom handlebars syntax highlighter for coderay #196

Merged
merged 1 commit into from
Dec 17, 2012
Merged

Custom handlebars syntax highlighter for coderay #196

merged 1 commit into from
Dec 17, 2012

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Dec 17, 2012

I've created a simple handlebars scanner for coderay:
rubychan/coderay#103

This pull request brings this custom branch into the ember site to sharpen up our code snippets. Here's a before / after shot:

without_handlebars_highlighting
with_handlebars_highlighting

It's not a terribly elaborate scanner, in that I didn't attempt to separate handlebars / ember specific keywords, but it does highlight comments, attribute names and values, double and triple staches, operators like =, etc.

By the way, we may want to include a new flag png for handlebars instead of reusing the html flag for template code. This will allow us to be more deliberate about snippets that are pure html vs those that include templates.

wagenet added a commit that referenced this pull request Dec 17, 2012
Custom handlebars syntax highlighter for coderay
@wagenet wagenet merged commit b5cf8b9 into emberjs:master Dec 17, 2012
@wagenet
Copy link
Member

wagenet commented Dec 17, 2012

Happy Dance

@jamesarosen
Copy link
Contributor

🐻 🍰 👻 👊 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants