[BUGFIX beta] Ensure Mixin.prototype.toString is defined. #12636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Mixin.prototype` is sealed after its initial definition, but `Mixin.prototype.toString` is assigned later in `ember-runtime/namespace`. This causes issues when `ember-template-compiler.js` is loaded before the rest of Ember (because the `Mixin.prototype` is sealed). Unfortunately, the debug functions (for `Object.seal`) does not work in the `ember-metal` package at this time. This fix is a temporary fix to allow the loading of `ember-template-compiler.js` to be before or after `ember.debug.js`. The more permanent fix is to ensure that `debugSeal` works in ember-metal properly.
|
And alternate solution to this, would be to remove this line. |
stefanpenner
added a commit
that referenced
this pull request
Nov 27, 2015
…xin-prototype [BUGFIX beta] Ensure Mixin.prototype.toString is defined.
would love to remove all that code :P But it would pwn globals toString without an alternative. I suspect finding an alternative would be good. #someday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mixin.prototypeis sealed after its initial definition, butMixin.prototype.toStringis assigned later inember-runtime/namespace. This causes issues whenember-template-compiler.jsis loaded before the rest of Ember (because theMixin.prototypeis sealed). Unfortunately, the debug functions (forObject.seal) does not work in theember-metalpackage at this time.This fix is a temporary fix ensures that the slot for
toStringexists onMixin.prototypeto allow the loading ofember-template-compiler.jsto be before or afterember.debug.js. The more permanent fix is to ensure thatdebugSealworks in ember-metal properly.Fixes #12623.