[BUGFIX release] Ensure rest arg positionalParams can be omitted. #12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying `postionalParams` like this:
```javascript
App.FooBarComponent = Ember.Component.extend();
App.FooBarComponent.reopenClass({
positionalParams: 'allTheThings'
});
```
You should be able to avoid using positional params by specifying
`allTheThings` as a hash argument:
```hbs
{{foo-bar allTheThings=blah}}
```
Unfortunately, we were triggering an assertion that you used a positional
param that conflicted with a hash param. This change fixes that
assertion by avoiding doing any work when no params are specified.
rwjblue
force-pushed
the
fix-rest-style-positional-params
branch
from
03cc682
to
d34aa11
Compare
rwjblue
added a commit
that referenced
this pull request
Oct 6, 2015
[BUGFIX release] Ensure rest arg positionalParams can be omitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying
postionalParamslike this:You should be able to avoid using positional params by specifying
allTheThingsas a hash argument:Unfortunately, we were triggering an assertion that you used a positional param that conflicted with a hash param. This change fixes that assertion by avoiding doing any work when no params are specified.
Fixes #12444.