-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta] fillIn test helper triggers input
event.
#11708
[BUGFIX beta] fillIn test helper triggers input
event.
#11708
Conversation
Looks good to me. |
I would learn toward |
@mixonic I'd argue that this is a missbehavior of the current release and prevents to use one of the cool features that 1.13 brought in into the toolchain. |
@cibernox - Unless a given bugfix is very high severity it should go into beta (not release). Also, seems easy enough to polyfill (via your own helper) if this is blocking you for past versions. |
@cibernox yeah, but we've also had people want key events for these. There is some dangerous line we walk on where these helpers are emulating user behavior mostly but not entirely (or over specifically). The balance is delicate, and thus I am +1 but feel it should go into a minor release and not patch. |
Nah, not very blocking since I can fire the event myself at the end. Just wondering what was the criteria to consider something a bugfix of the current release or the next one. |
949abb7
to
e57d6be
Compare
input
event.input
event.
tests appear sad. @cibernox are there concerns with emitting both change + input (mostly just the order) |
The new `<input type="text" oninput={{action "search"}}>` is very fast but at the moment is unusable bacause ember test helpers doesn't fire that event. Fixed.
e57d6be
to
14124e9
Compare
@stefanpenner rebuilding. The correct order of the events is keydown > keyup > keypress > input > change according to MDN |
@stefanpenner are you +1 for this? I'd like to land it, please merge away if seems good to you. |
thanks for the research, as long as this is preserved |
Input is before change here. |
[BUGFIX beta] fillIn test helper triggers `input` event.
I added a test explicitly for checking that: https://github.com/emberjs/ember.js/pull/11708/files#diff-f834632dddeade3002a271a3e9fb68a3R613 (i'm not firing key events) |
Nice work dude! |
The new
<input type="text" oninput={{action "search"}}>
is very fastbut at the moment is unusable bacause ember test helpers doesn't fire
that event.
Fixed.