Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular import between @ember/object/index and @ember/object/observable #20709

Closed
patricklx opened this issue Jun 20, 2024 · 2 comments
Closed

Comments

@patricklx
Copy link
Contributor

patricklx commented Jun 20, 2024

🐞 Describe the Bug

there is a circular import between
'@ember/object/index';
and
'@ember/object/observable';
and
@ember/array/index.

those files are actually also importing from @ember/-internals/metal, so they could use that directly to access get, set

https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/observable.ts#L14
https://github.com/emberjs/ember.js/blob/main/packages/%40ember/object/index.ts#L13

this causes rollup to sometimes build it wrong and have runtime errors later. (testing with vite+dep optimizer)

@patricklx patricklx changed the title circular impoer circular import between @ember/object/index and @ember/object/observable Jun 20, 2024
@kategengler
Copy link
Member

cc @ef4

@ef4
Copy link
Contributor

ef4 commented Aug 28, 2024

Fixed in #20734

@ef4 ef4 closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants