Ember 3.0 - Failed assertion when JSON.stringify -ing an Ember Object

[mani-mishra]

Upgrading to Ember 3.0 and using JSON.stringify, results in following failed assertion

Assertion Failed: You attempted to access `someValue.toJSON` (on `<(unknown mixin):ember2486>`), but `someValue` is a computed property.↵↵Due to certain internal implementation details of Ember,

I read the linked RFCs and discussion and I understand this is just a precautionary assertion, but this breaks JSON.stringify usage.

https://github.com/douglascrockford/JSON-js/blob/master/json2.js#L237-L238

[rwjblue]

Thank you for reporting!

We need to add toJSON as an exception in this list:

ember.js/packages/ember-metal/lib/properties.js

Lines 126 to 130 in 3240b4a

	property === 'toString' ||
	property === 'valueOf' ||
	property === 'inspect' ||
	Symbol && property === Symbol.toPrimitive ||
	Symbol && property === Symbol.toStringTag

[chancancode]

Probably here too?

ember.js/packages/ember-metal/lib/properties.js

Line 150 in 3240b4a

trap.toString = trap.valueOf = () => '[COMPUTED PROPERTY]';