Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with classNames given to a component in a template (duplicates in DOM) #11600

Closed
fpauser opened this issue Jun 30, 2015 · 8 comments · Fixed by #12184
Closed

Problem with classNames given to a component in a template (duplicates in DOM) #11600

fpauser opened this issue Jun 30, 2015 · 8 comments · Fixed by #12184
Labels

Comments

@fpauser
Copy link
Contributor

fpauser commented Jun 30, 2015

See http://jsbin.com/humehu/edit?html,js,output

Expected DOM:
[..] class="ember-view test-comp test-comp-big" [..]

Generated DOM:
[..] class="test-comp-big ember-view test-comp test-comp-big" [..]

@stefanpenner
Copy link
Member

can confirm canary also fails: http://jsbin.com/funovotegi/edit?html,js,output

@fpauser
Copy link
Contributor Author

fpauser commented Jul 1, 2015

Added a failing-test: #11609

@stacylondon
Copy link

I'm using 1.13.7 and not only am I seeing the class output twice, the 2nd is being output with a space between every letter. Here is a jsbin for reference: http://emberjs.jsbin.com/tiruwo/edit?html,css,js,output. I would also expect the special-class case to include ember-view but it doesn't (additive, not completely replace).

Expected DOM:
[..] class="ember-view default-class special-class [..]

Generated DOM:
[..] class="special-class s p e c i a l - c l a s s [..]

@rwjblue
Copy link
Member

rwjblue commented Aug 17, 2015

This was fixed by #12073 and released in 1.13.8.

@rwjblue rwjblue closed this as completed Aug 17, 2015
@stacylondon
Copy link

Thanks! I updated my jsbin to point to 1.13.8 and the issue with spaces in between letters is fixed as well as the class names not being additive. However, "special-class" is still being output twice. http://emberjs.jsbin.com/tiruwo/edit?html,css,js,output

@rwjblue
Copy link
Member

rwjblue commented Aug 18, 2015

I vaguely think that there is another open issue for duplicated classes (but can't search ATM). Can you double check, and open one if you can't find it?

@stacylondon
Copy link

Will do, thanks!

@stacylondon
Copy link

Didn't see anything that looked related so opened #12146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants