-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with classNames given to a component in a template (duplicates in DOM) #11600
Comments
can confirm canary also fails: http://jsbin.com/funovotegi/edit?html,js,output |
Added a failing-test: #11609 |
I'm using 1.13.7 and not only am I seeing the class output twice, the 2nd is being output with a space between every letter. Here is a jsbin for reference: http://emberjs.jsbin.com/tiruwo/edit?html,css,js,output. I would also expect the special-class case to include ember-view but it doesn't (additive, not completely replace). Expected DOM: Generated DOM: |
This was fixed by #12073 and released in 1.13.8. |
Thanks! I updated my jsbin to point to 1.13.8 and the issue with spaces in between letters is fixed as well as the class names not being additive. However, "special-class" is still being output twice. http://emberjs.jsbin.com/tiruwo/edit?html,css,js,output |
I vaguely think that there is another open issue for duplicated classes (but can't search ATM). Can you double check, and open one if you can't find it? |
Will do, thanks! |
Didn't see anything that looked related so opened #12146. |
See http://jsbin.com/humehu/edit?html,js,output
Expected DOM:
[..] class="ember-view test-comp test-comp-big" [..]
Generated DOM:
[..] class="test-comp-big ember-view test-comp test-comp-big" [..]
The text was updated successfully, but these errors were encountered: